Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix build error on e2e tests #53

Merged
merged 3 commits into from
May 23, 2024
Merged

test: fix build error on e2e tests #53

merged 3 commits into from
May 23, 2024

Conversation

ykim-akamai
Copy link
Contributor

📝 Description

Fixing go build issue when running e2e playbook

STDERR:

go: updates to go.mod needed; to update it:
        go mod tidy

✔️ How to Test

https://github.com/ykim-1/go-metadata/actions/runs/9105766715/job/25031895232

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@ykim-akamai ykim-akamai requested a review from a team as a code owner May 16, 2024 03:06
@ykim-akamai ykim-akamai requested review from jriddle-linode and yec-akamai and removed request for a team May 16, 2024 03:06
jriddle-linode
jriddle-linode approved these changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@jriddle-linode jriddle-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yec-akamai
yec-akamai approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ykim-akamai ykim-akamai merged commit b331979 into linode:main May 23, 2024
1 check passed
@zliang-akamai zliang-akamai added the testing for updates to the testing suite in the changelog. label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yec-akamai yec-akamai yec-akamai approved these changes

@jriddle-linode jriddle-linode jriddle-linode approved these changes

Assignees
No one assigned
Labels
testing for updates to the testing suite in the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ykim-akamai @jriddle-linode @yec-akamai @zliang-akamai